Skip to content

Refactor 404 error page to use div instead of p for search form #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor 404 error page to use div instead of p for search form #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## 8.3.4-wip
* The URL for category pages now uses _category name_ instead of
_category `displayName`_.
* Refactor 404 error page to use div instead of p for search form.

## 8.3.3

Expand Down
48 changes: 30 additions & 18 deletions lib/templates/404error.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,39 @@
{{>head}}

<div id="dartdoc-main-content" class="main-content">
<h1>404: Something's gone wrong :-(</h1>
<div id="dartdoc-main-content" class="main-content">
<h1>404: Something's gone wrong :-(</h1>

<section class="desc">
<p>You've tried to visit a page that doesn't exist. Luckily this site
has other <a href="index.html">pages</a>.</p>
<p>If you were looking for something specific, try searching:
<section class="desc">
<p>
You've tried to visit a page that doesn't exist. Luckily this site has
other <a href="index.html">pages</a>.
</p>
<div>
If you were looking for something specific, try searching:
<form class="search-body" role="search">
<input type="text" id="search-body" autocomplete="off" disabled class="form-control typeahead" placeholder="Loading search...">
<input
type="text"
id="search-body"
autocomplete="off"
disabled
class="form-control typeahead"
placeholder="Loading search..."
/>
</form>
</p>
</div>
</section>
</div>
<!-- /.main-content -->

</section>
</div> <!-- /.main-content -->
<div id="dartdoc-sidebar-left" class="sidebar sidebar-offcanvas-left">
{{>search_sidebar}}
<h5>
<span class="package-name">{{self.name}}</span>
<span class="package-kind">{{self.kind}}</span>
</h5>
{{>packages}}
</div>

<div id="dartdoc-sidebar-left" class="sidebar sidebar-offcanvas-left">
{{>search_sidebar}}
<h5><span class="package-name">{{self.name}}</span> <span class="package-kind">{{self.kind}}</span></h5>
{{>packages}}
</div>

<div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right">
</div>
<div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right"></div>

{{>footer}}