Skip to content

Correct links to remote, canonical libraries #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

srawlins
Copy link
Member

Fixes #3891

In this example, the file package exports elements from dart:io. So when --link-to-remote is used, the canonical library for those exported elements should be api.dart.dev.

Also some cleaning:

  • Move _searchForCanonicalLibrary from ModelElement to canonicalization.dart, keeping more canonicalization logic together.
  • This allows us to make Canonicalization private.
  • Make some comments in ModelElement doc-comments.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Fixes dart-lang#3891

In this example, the **file** package exports elements from `dart:io`. So when
`--link-to-remote` is used, the canonical library for those exported elements
should be `api.dart.dev`.

Also some cleaning:

* Move `_searchForCanonicalLibrary` from ModelElement to
  `canonicalization.dart`, keeping more canonicalization logic together.
* This allows us to make `Canonicalization` private.
* Make some comments in ModelElement doc-comments.
@srawlins
Copy link
Member Author

Ready, @dart-lang/analyzer-team

@srawlins srawlins merged commit 2e64c2b into dart-lang:main Oct 22, 2024
7 checks passed
@srawlins srawlins deleted the exported-sdk branch October 22, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixing references of local class to the SDK class with the same name.
2 participants