Skip to content

In the buildbot CI step, reset built web files before trying to publish #3896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Oct 2, 2024

These files can have minor differences in them (depending on the version of Dart?), so that it is difficult for them to always be identical to the ones checked in, during CI. Then there is a new warning that pub publish --dry-run produces, if the current git checkout is not clean: dart-lang/pub#4373. We need to reset these files to avoid that warning.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

These files can have minor differences in them (depending on the version of
Dart?), so that it is difficult for them to always be identical to the ones
checked in, during CI. Then there is a new warning that `pub publish --dry-run`
produces, if the current git checkout is not clean:
dart-lang/pub#4373. We need to reset these files to
avoid that warning.
@srawlins
Copy link
Member Author

srawlins commented Oct 2, 2024

CC @dart-lang/analyzer-team

@srawlins srawlins merged commit 4c82b49 into dart-lang:main Oct 3, 2024
7 checks passed
@srawlins srawlins deleted the new-try-publish branch October 3, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants