Handle reexports of extensions in dartdoc #2045
Conversation
| } | ||
| for (LibraryElement le in _libraryElement.exportedLibraries) { | ||
| extensionElements.addAll(le.definingCompilationUnit.extensions | ||
| .where((t) => _exportedNamespace.definedNames.values.contains(t.name))); |
There was a problem hiding this comment.
I'm worried this might not do the right thing. Consider files foo.dart and bar.dart, each of which defines a distinct extension called E. Then if we have a library like this:
export 'foo.dart' show E;
export 'bar.dart' hide E;Then I think both Es will get included in extensionElements, because both of them have a name that matches a name that exists in _exportedNamespace.
The best correct approach I can currently think of is:
- Expose an analyzer API to allow clients to figure out which elements are actually exported by an
ExportElement(e.g. we could expose dartdoc to filter a set of elements via namespace combinators (we could moveNamespaceBuilder._applyCombinatorstoExportElementand re-name it appropriately) - Change this code to iterate through the export elements rather than the exported libraries, so that it can use the newly exposed API to figure out exactly which extensions are shown.
It's ok with me if you want to file an issue and address this in a later PR.
There was a problem hiding this comment.
Yes, I'm seeing this now that I'm looking more closely at the library scope code in the analyzer. It looks like this has always been wrong in the class implementation. The "LibraryExportScope" I mentioned in chat the other day is probably the right solution for this, too.
There was a problem hiding this comment.
The fix for this is taking a while, I think I will go ahead and deal with this in a followup PR.
Fixes #2032.
This implements canonicalization with export handling for extensions, but not yet their methods. (All methods of extensions are assumed canonical with their extension, which is usually the case.) Largely based on the class handling for the same problem, which has also been cleaned up a bit.