This repository was archived by the owner on Feb 22, 2018. It is now read-only.
refactor(dccd): Simplify both the interface and the implementation #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
added a commit
to vicb/angular.dart
that referenced
this pull request
Apr 21, 2014
dart-archive#909 cont'd. This commit is for the map changes (909 is for collection).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mhevery this is the change we've talked about last week.
This PR handle the Collections only, Maps are still TBD.
There might be a few things to polish but I think the PR is mergeable. It brings:
AddedItem,RemovedItem,MovedItemand the likes are implementation details. The IF now only exposes aCollectionChangeItem),There's not perf impact to expect for this change (might be marginally faster ?) however having a simpler code is always good for maintainability.
If you like it please merge it, I'll do the map as part of an other PR. Thanks.
/cc @caitp