Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

chore(scripts): Cleanup #906

Merged
merged 1 commit into from
Apr 24, 2014
Merged

chore(scripts): Cleanup #906

merged 1 commit into from
Apr 24, 2014

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 15, 2014

Clean scripts

was:

To match more closely the tests run by TravisCI.

This is important as some tests might fail on FF only.

I've noticed this while working on #861: some tests would fail on FF and be ok on Chrome. This tiny change could ease dev life.

@chalin
Copy link
Contributor

chalin commented Apr 15, 2014

Travis tests run on FF too?

@vicb
Copy link
Contributor Author

vicb commented Apr 15, 2014

Yes sir https://github.com/angular/angular.dart/blob/master/scripts/travis/build.sh#L62

@vicb vicb added cla: yes and removed cla: no labels Apr 15, 2014
@mhevery mhevery self-assigned this Apr 15, 2014
@mhevery
Copy link
Contributor

mhevery commented Apr 15, 2014

@vicb I would like to move all *.sh scripts to scripts folder and make them consistent with the ones which are already there. Maybe this would be a good time.

BTW, the core team does not use run-test.sh

vicb added a commit that referenced this pull request Apr 15, 2014
@vicb @mhevery
chore(run-test): Adding Firefox support in run-test.sh
14b0dac 
To match more closely the tests run by TravisCI.

This is important as some tests might fail on FF only.

Closes #906
@vicb
Copy link
Contributor Author

vicb commented Apr 16, 2014

I can take care of moving the scripts, I'll update the PR.

BTW, the core team does not use run-test.sh

How do you run test on FF ? A debug config in webstorm ?
Can't we keep run-test for people not using ws ?

@chalin
Copy link
Contributor

chalin commented Apr 16, 2014

I'm not use WS but if all you guys are ... maybe I should.

@vicb
Copy link
Contributor Author

vicb commented Apr 16, 2014

@chalin you should at least get the evaluation version. I do think it"s really worth the money.

@vicb vicb changed the title chore(run-test): Adding Firefox support in run-test.sh chore(scripts): Cleanup Apr 16, 2014
@vicb
Copy link
Contributor Author

vicb commented Apr 16, 2014

@mhevery I have updated the PR. Not sure if this is what was expected. Comments welcome.

vicb added a commit that referenced this pull request Apr 16, 2014
@vicb @mhevery
chore(run-test): Adding Firefox support in run-test.sh
00de0b6 
To match more closely the tests run by TravisCI.

This is important as some tests might fail on FF only.

Closes #906
vicb added a commit that referenced this pull request Apr 17, 2014
@vicb @mhevery
chore(run-test): Adding Firefox support in run-test.sh
58063b6 
To match more closely the tests run by TravisCI.

This is important as some tests might fail on FF only.

Closes #906
@vicb vicb closed this in 926f0f1 Apr 17, 2014
@vicb
Copy link
Contributor Author

vicb commented Apr 23, 2014

@mhevery not sure if this was closed on purpose ?

@vicb vicb reopened this Apr 23, 2014
@mhevery
Copy link
Contributor

mhevery commented Apr 24, 2014

@vicb I think the closing may have been a mistake.

@mhevery
Copy link
Contributor

mhevery commented Apr 24, 2014

LGTM, please rebase and merge

@mhevery mhevery merged commit 3dfa172 into dart-archive:master Apr 24, 2014
@vicb vicb deleted the 0415-testff branch April 24, 2014 07:34
vicb added a commit that referenced this pull request Apr 24, 2014
@vicb @mhevery
chore(run-test): Adding Firefox support in run-test.sh
9878e6c 
To match more closely the tests run by TravisCI.

This is important as some tests might fail on FF only.

Closes #906
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicb @chalin @mhevery