Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Fix typos - lets -> let's #903

Closed
wants to merge 1 commit into from
Closed

Fix typos - lets -> let's #903

wants to merge 1 commit into from

Conversation

beatgammit
Copy link
Contributor

No description provided.

@mhevery
Copy link
Contributor

mhevery commented Apr 15, 2014

Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road.

For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html

@beatgammit
Copy link
Contributor Author

Signed.

@beatgammit
Copy link
Contributor Author

I added another small fix to indentation on routing page.

@beatgammit
Copy link
Contributor Author

I got dartanalyzer warnings about router not having an addRoute function. The example (Chapter 6) gives router.configure, whereas the tests use router.root. This at least prevents compile errors, but I don't know which way is advised as the standard way to do this.

@vicb
Copy link
Contributor

vicb commented Apr 15, 2014

@beatgammit could you please squash your commits and update the commit message according the guidelines in contributor.md, ie "doc: fix API docs".

Thanks.

*
* void initRoutes(Router router, RouteViewFactory view) {
* router
* router.root
* ..addRoute(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be indented with 4ws, could you please update

@vicb
Copy link
Contributor

vicb commented Apr 15, 2014

The router API has been changing lately. To make sure what you have is correct, you should probably run a pub upgrade before checking.

The tutorial examples are for the latest stable release wight might different from the dev version in the master branch.

- also fixed indentation to match Dart style guide
@beatgammit
Copy link
Contributor Author

I've squashed my commits and updated indentation. Let me know if there's anything else.

@vicb
Copy link
Contributor

vicb commented Apr 15, 2014

Have you arranged the CLA stuff ?

@mhevery
Copy link
Contributor

mhevery commented Apr 15, 2014

@beatgammit looks like you signed it with a different email address than the one you use for github. Could you resign with the same one.

@mhevery mhevery self-assigned this Apr 15, 2014
mhevery pushed a commit that referenced this pull request Apr 15, 2014
- also fixed indentation to match Dart style guide

Closes #903
@beatgammit
Copy link
Contributor Author

Sorry about that. I've re-signed.

@mhevery
Copy link
Contributor

mhevery commented Apr 16, 2014

Achievement unlocked: CLA signature found!

@beatgammit
Copy link
Contributor Author

Awesome. Sorry for the drama. Hopefully I'll be able to contribute something a little more worthwhile than a few doc fixes in the near future.

mhevery pushed a commit that referenced this pull request Apr 16, 2014
- also fixed indentation to match Dart style guide

Closes #903
mhevery pushed a commit that referenced this pull request Apr 17, 2014
- also fixed indentation to match Dart style guide

Closes #903
@mhevery mhevery closed this in 3f62b4b Apr 17, 2014
mhevery pushed a commit that referenced this pull request Apr 24, 2014
- also fixed indentation to match Dart style guide

Closes #903
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants