-
Notifications
You must be signed in to change notification settings - Fork 248
Conversation
Thanks for your contribution! In order for us to be able to accept it, we ask you to sign our CLA (contributor's license agreement). CLA is important for us to be able to avoid legal troubles down the road. For individuals (a simple click-through form): http://code.google.com/legal/individual-cla-v1.0.html |
Signed. |
I added another small fix to indentation on routing page. |
I got |
@beatgammit could you please squash your commits and update the commit message according the guidelines in contributor.md, ie "doc: fix API docs". Thanks. |
* | ||
* void initRoutes(Router router, RouteViewFactory view) { | ||
* router | ||
* router.root | ||
* ..addRoute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be indented with 4ws, could you please update
The router API has been changing lately. To make sure what you have is correct, you should probably run a The tutorial examples are for the latest stable release wight might different from the dev version in the master branch. |
- also fixed indentation to match Dart style guide
I've squashed my commits and updated indentation. Let me know if there's anything else. |
Have you arranged the CLA stuff ? |
@beatgammit looks like you signed it with a different email address than the one you use for github. Could you resign with the same one. |
- also fixed indentation to match Dart style guide Closes #903
Sorry about that. I've re-signed. |
Achievement unlocked: CLA signature found! |
Awesome. Sorry for the drama. Hopefully I'll be able to contribute something a little more worthwhile than a few doc fixes in the near future. |
- also fixed indentation to match Dart style guide Closes #903
- also fixed indentation to match Dart style guide Closes #903
- also fixed indentation to match Dart style guide Closes #903
No description provided.