This repository was archived by the owner on Feb 22, 2018. It is now read-only.
fix: add docs to NgZone and fix type declaration of onError, onTurnDone #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added to my merge queue. Just FYI for next time: we follow this naming convention for commits: https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md#commit-message-format |
mhevery
pushed a commit
that referenced
this pull request
Apr 15, 2014
mhevery
pushed a commit
that referenced
this pull request
Apr 16, 2014
mhevery
pushed a commit
that referenced
this pull request
Apr 17, 2014
mhevery
pushed a commit
that referenced
this pull request
Apr 24, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think onError, onTurnDone being assignable variables instead of overridable methods makes describing this thing a little wonky