This repository was archived by the owner on Feb 22, 2018. It is now read-only.
test(symbols): Track the symbols we export from the angular library #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it('should not export symbols that we do not know about', () { | ||
| _getSymbolsFromLibrary(String libraryName) { | ||
| var names = []; | ||
| var SYMBOL_NAME = new RegExp('"(.*)"'); |
There was a problem hiding this comment.
are regexp greedy by default ? then you probably want .*? but [^"]* might be more efficient (backtracking)
|
I like this idea. We should merge this in. Could we add comments next to the imports which we believe should not be showing up? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398