This repository was archived by the owner on Feb 22, 2018. It is now read-only.
docs(contributing): add developer docs explaining how to setup and run tests #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n tests - Create a first version of developer documentation explaining how to setup and run AngularDart tests locally and on Travis. - Update `CONTRIBUTING.md` to refer to this new doc. Addresses dart-archive#322. Assumes dart-archive#545.
| This document describes how to set up your development environment to build and test AngularDart, and | ||
| explains the basic mechanics of using `git`, `node`, and `npm`. | ||
|
|
||
| <!--, `grunt`, and `bower`--> |
There was a problem hiding this comment.
we don't use grunt / bower please remove
|
This looks great. address my comments and should be good to go. |
[Misko's feedback](dart-archive#548 (comment) 650853).
|
Done. |
|
Also can we rename to DEVELOPER.md just to be consistent with CONTRIBUTING.md. I will take another pass on this later and try to comment or merge. |
|
Renamed for you and merged |
|
Thanks (sorry, I was in class this morning). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup and run AngularDart tests locally and on Travis.
CONTRIBUTING.mdto refer to this new doc.Addresses #322. Assumes #545.