This repository was archived by the owner on Feb 22, 2018. It is now read-only.
refactor(NgElement): NgElement inject RootScope instead of Scope. #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an awkward pattern. It requires a call to appInjector each time something gets ngElement. Could you get a reference to RootScope into DirectiveInjector instead? |
NgElement only uses scope to access rootScope, so now we directly inject RootScope. This is needed for future change dart-archive#1429 which disallows Scope injection into controllers. Since NgElement depends on scope it would also be disallowed, unless we change it to directly use RootScope.
|
Rebased and resolved James' concern offline. Since ngElement is lazily created and most directives do not use it, the cost of eagerly grabbing rootScope from appInjector might be too much. Also ngElement is cached in the directive injector. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NgElement only uses scope to access rootScope, so now we directly inject
RootScope.
This is needed for future change #1429 which disallows Scope injection
into controllers. Since NgElement depends on scope it would also be
disallowed, unless we change it to directly use RootScope.