This repository was archived by the owner on Feb 22, 2018. It is now read-only.
feat(mocks): change MockHttpBackend to define assertions on flush. #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new methods (`flushGET`, `flushPOST`, etc) to the `MockHttpBackend` class to allow defining assertions on flush. These methods add a new expectation and then flush all the pending requests until they find the one matching the expectation.
BREAKING CHANGE:
Unexpected requests are detected only when `flush` is called.
Before:
backend("GET", /some"); //throws here if `/some` has not been defined
After:
backend("GET", /some"); //no problem, just records the request
backend.flush(); //throws here
Closes dart-archive#900
vsavkin
added a commit
to vsavkin/angular.dart
that referenced
this pull request
Sep 7, 2014
vsavkin
added a commit
that referenced
this pull request
Sep 11, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mixup with merging #1206.
This is the same PR rebased on top of master.