Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

feat(scripts): pick-pr #1394

Closed
wants to merge 1 commit into from
Closed

Conversation

jbdeboer
Copy link
Contributor

A script to build up staging branches.

@vicb
Copy link
Contributor

vicb commented Aug 27, 2014

I have to think a little bit about this.

Some ideas:

@jbdeboer
Copy link
Contributor Author

The pull/$PR/head approach is better, thank you.

We are not going to change from cherry-picking to merging right now. It may be a good idea, but that is a discussion we need to have with the wider team.

@jbdeboer
Copy link
Contributor Author

Let me know when this is 'mergeable'.

@chirayuk may have an opinion as well.

@vicb
Copy link
Contributor

vicb commented Aug 28, 2014

Would expanding the "upstream" alias ([email protected]:angular/angular.dart.git) work ?
("upstream" is called "origin" for me)

Otherwise it should be configurable through an environment variable (which could default to "upstream").

LGTM once this issue is adressed

@jbdeboer
Copy link
Contributor Author

Yes, that works and makes the script more robust.

@jbdeboer jbdeboer closed this in 3090a19 Aug 29, 2014
jbdeboer added a commit that referenced this pull request Aug 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants