This repository was archived by the owner on Feb 22, 2018. It is now read-only.
perf(dccd): Drop useless checks #1256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in _recordAdd(), previous could never be null as the list is never empty (it has at least a marker). in _recordRemove(), when the list is composed of a single record, it must be the record we're trying to remove (and we assert that).
|
LGTM |
vicb
added a commit
that referenced
this pull request
Aug 5, 2014
in _recordAdd(), previous could never be null as the list is never empty (it has at least a marker). in _recordRemove(), when the list is composed of a single record, it must be the record we're trying to remove (and we assert that). Closes #1256
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Aug 7, 2014
in _recordAdd(), previous could never be null as the list is never empty (it has at least a marker). in _recordRemove(), when the list is composed of a single record, it must be the record we're trying to remove (and we assert that). Closes dart-archive#1256
|
This change does not work and breaks some apps. It has no real benefit. I'm reverting it. |
|
@chirayuk Do you have more info on how the apps break ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in _recordAdd(), previous could never be null as the list is never empty (it has at least a marker).
in _recordRemove(), when the list is composed of a single record, it must be the record we're trying to remove (and we assert that).
The perf gain should be marginal and is not reliably measure with the wg benchmark (hidden by the noise)