This repository was archived by the owner on Feb 22, 2018. It is now read-only.
reflactor(parser): rename DynamicParser into Parser #1251
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,13 +6,17 @@ import 'package:angular/core/parser/syntax.dart'; | |||
| import 'package:angular/core/parser/characters.dart'; | |||
| import 'package:angular/utils.dart' show isReservedWord; | |||
|
|
|||
| class DynamicParserImpl { | |||
| Expression parseExpression(Lexer lexer, ParserBackend backend, String input) { | |||
| return new _ParseExpression(lexer, backend, input).parseChain(); | |||
|
@chirayuk I think the only thing that has to change is: import 'package:angular/core/parser/parser_dynamic.dart';to: import 'package:angular/core/parser/dynamic_closure_map.dart';I can rebase this PR. |
vsavkin
force-pushed
the
merge_dynamic_parser_into_parser
branch
from
063fb0a to
2711232
Compare
vsavkin
force-pushed
the
merge_dynamic_parser_into_parser
branch
from
2711232 to
76d5aba
Compare
Since there is only one implementation of the Parser interface, which is used for both dynamic and static deployments, calling it DynamicParser is misleading. - Remove the Parser interface - Rename rename DynamicParser into Parser - Rename DynamicParserBackend into RuntimeParserBackend
vsavkin
force-pushed
the
merge_dynamic_parser_into_parser
branch
from
76d5aba to
76eef19
Compare
vsavkin
added a commit
to vsavkin/angular.dart
that referenced
this pull request
Sep 10, 2014
Since there is only one implementation of the Parser interface, which is used for both dynamic and static deployments, calling it DynamicParser is misleading. - Remove the Parser interface - Rename rename DynamicParser into Parser - Rename DynamicParserBackend into RuntimeParserBackend Closes dart-archive#1251
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is only one implementation of the Parser interface, which is used for both dynamic and static deployments, calling it DynamicParser is misleading.