This repository was archived by the owner on Feb 22, 2018. It is now read-only.
perf(bp): add min/max numbers to bp report #1233
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -177,7 +177,8 @@ bp.Report.getTimesPerAction = function(name) { | |||
| tpa[c] = { | |||
| recent: undefined, | |||
| history: [], | |||
| avg: {} | |||
| avg: {}, | |||
| minmax: {} | |||
There was a problem hiding this comment.
What about
minmax {
max: 0,
min: double.MAX_FINITE,
}
to simplify the code ?
edit: or even min and max ad 2 fields ?
|
lgtm, 1 comment |
|
well actually may be one other comment, should it be labeled "perf" or "chore/feat" ? ("perf" being reserved for changes that actually improve perf) |
|
Thanks for the quick review vicb! Take another look. Also, I am new to this dev flow. I used commit --amend and push -f, let me know if I am doing something wrong. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark fluctuates quite a bit (even with the last 20 window), so I find the minimum time taken useful.