Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Update pubspec Intl version #1203

Closed

Conversation

alan-knight
Copy link
Contributor

No description provided.

@alan-knight
Copy link
Contributor Author

@jbdeboer @mhevery Can you guys take a look at this? It's a problem for being able to use updated Intl versions, which have some important fixes. Note that one of the tests has to change because it relies on CLDR data that's changed.

@mhevery
Copy link
Contributor

mhevery commented Jul 29, 2014

Please squash the SHAs together and follow our commit message guidelines: https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md#commit Than the PR should be ready to merge.

@vicb
Copy link
Contributor

vicb commented Jul 29, 2014

I have a question about this PR, we now have

intl: '>=0.8.7 <0.12.0' which means to the code is supposed to work with all those version.

The updated test obviously does not with 0.10 (because it needed to be updated). While this is not a big deal here, what would be the best way to handle this in general ? Should we not allow versions to span over BC breaks (intl: '>=0.11.0 <0.12.0') ?

Once again this is not a problem here, just thinking about general case.

@alan-knight
Copy link
Contributor Author

It's a good point. I think the general rule is that the version shouldn't only span over BC breaks if the breaking change doesn't affect the way this package uses it. For example, a breaking change in Intl's message handling doesn't affect Angular, since it doesn't use it, but a change to date formatting does. Possibly a better fix for the test would be to change it to test a locale whose data didn't change between the two versions of CLDR and then it should work with all versions.

@alan-knight
Copy link
Contributor Author

Squashed and fixed commit message.

@chirayuk chirayuk closed this in 0c65be8 Jul 29, 2014
chirayuk pushed a commit that referenced this pull request Jul 29, 2014
Angular's pubspec for intl spans versions with breaking changes.  For
Angular, a change in date formatting would be a breaking change but
changes do to CLDR updates are not breaking changes.  This commit
updates a test to swap out a locale with a CLDR update to one that
wasn't updated to enable it to pass across the CLDR breaking change.

Closes #1203
@vicb
Copy link
Contributor

vicb commented Jul 30, 2014

@alan-knight for some reason I'm stuck with intl 0.8.10+4 (0.11.3 available) even after a pub upgrade (with your modifs). I can't figure out why I can not get a newer version, any idea ? (pub deps does not help).
If a set the req to intl: '>=0.11.0 <0.12.0' then 0.11.3 is used.
Isn't pub upgrade supposed to get the highest possible version, is this a dartbug.com ?

@alan-knight
Copy link
Contributor Author

I think this is probably because of the thing Bob Nystrom was talking about
in the mailing list with analyzer dependencies. I'll broaden the dependency
in Intl and that might help some.

On Wed, Jul 30, 2014 at 1:35 AM, Victor Berchet [email protected]
wrote:

@alan-knight https://github.com/alan-knight for some reason I'm stuck
with intl 0.8.10+4 (0.11.3 available) even after a pub upgrade (with your
modifs). I can't figure out why I can not get a newer version, any idea ? (pub
deps does not help).
If a set the req to intl: '>=0.11.0 <0.12.0' then 0.11.3 is used.
Isn't pub upgrade supposed to get the highest possible version, is this a
dartbug.com ?


Reply to this email directly or view it on GitHub
#1203 (comment).

@alan-knight
Copy link
Contributor Author

I published an updated Intl that allows current analyzer. I'm not sure if that will help your case or not. If I do a pub upgrade on angular it gets the current version of Intl.

@vicb
Copy link
Contributor

vicb commented Jul 31, 2014

@alan-knight great, thanks !

dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this pull request Aug 7, 2014
Angular's pubspec for intl spans versions with breaking changes.  For
Angular, a change in date formatting would be a breaking change but
changes do to CLDR updates are not breaking changes.  This commit
updates a test to swap out a locale with a CLDR update to one that
wasn't updated to enable it to pass across the CLDR breaking change.

Closes dart-archive#1203
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants