-
Notifications
You must be signed in to change notification settings - Fork 248
Conversation
Please squash the SHAs together and follow our commit message guidelines: https://github.com/angular/angular.dart/blob/master/CONTRIBUTING.md#commit Than the PR should be ready to merge. |
I have a question about this PR, we now have
The updated test obviously does not with Once again this is not a problem here, just thinking about general case. |
It's a good point. I think the general rule is that the version shouldn't only span over BC breaks if the breaking change doesn't affect the way this package uses it. For example, a breaking change in Intl's message handling doesn't affect Angular, since it doesn't use it, but a change to date formatting does. Possibly a better fix for the test would be to change it to test a locale whose data didn't change between the two versions of CLDR and then it should work with all versions. |
Squashed and fixed commit message. |
Angular's pubspec for intl spans versions with breaking changes. For Angular, a change in date formatting would be a breaking change but changes do to CLDR updates are not breaking changes. This commit updates a test to swap out a locale with a CLDR update to one that wasn't updated to enable it to pass across the CLDR breaking change. Closes #1203
@alan-knight for some reason I'm stuck with |
I think this is probably because of the thing Bob Nystrom was talking about On Wed, Jul 30, 2014 at 1:35 AM, Victor Berchet [email protected]
|
I published an updated Intl that allows current analyzer. I'm not sure if that will help your case or not. If I do a pub upgrade on angular it gets the current version of Intl. |
@alan-knight great, thanks ! |
Angular's pubspec for intl spans versions with breaking changes. For Angular, a change in date formatting would be a breaking change but changes do to CLDR updates are not breaking changes. This commit updates a test to swap out a locale with a CLDR update to one that wasn't updated to enable it to pass across the CLDR breaking change. Closes dart-archive#1203
No description provided.