This repository was archived by the owner on Feb 22, 2018. It is now read-only.
perf(scope): Cache the Scope.watch AST. #1173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes NgClass 20% faster. This will effect any Scope.watch() calls.
|
two remarks:
|
|
@vicb, what information do you have in mind? Having the cache in Scope.watch vs ASTParser: the code that is using Scope.watchAST does not need to cache their ASTs since they are computed outside the critical path -- adding those ASTs to the cache would increase memory pressure since the ASTs will live forever. |
|
Where do we observe the speed boost ? a benchmark, a real-life app, ... |
|
JS/Dart would also be important |
|
@IgorMinar has a benchmark. I will prod him to publish it. |
|
@IgorMinar @vicb See above. #1173 (comment) |
jbdeboer
added a commit
that referenced
this pull request
Jun 25, 2014
Makes NgClass 20% faster. This will effect any Scope.watch() calls. Closes #1173
jbdeboer
added a commit
that referenced
this pull request
Jun 25, 2014
Makes NgClass 20% faster. This will effect any Scope.watch() calls. Closes #1173
jbdeboer
added a commit
that referenced
this pull request
Jun 25, 2014
Makes NgClass 20% faster. This will effect any Scope.watch() calls. Closes #1173
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
Makes NgClass 20% faster. This will effect any Scope.watch() calls. Closes dart-archive#1173
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Jul 16, 2014
Makes NgClass 20% faster. This will effect any Scope.watch() calls. Closes dart-archive#1173
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes NgClass 20% faster. This will effect any Scope.watch() calls.