Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

fix(change_detector): Fix for detecting NanN moves in collections #1149

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 12, 2014

Closes #1136

@vicb vicb added cla: yes and removed cla: no labels Jun 12, 2014
@vicb
Copy link
Contributor Author

vicb commented Jun 13, 2014

Some details about this PR:

  • Factorize loose identity in _looseIdentical() -> identical which also support NaN and String test by value - the code was used at a few different places and should have been used at even more places.
  • Add support for detecting NaN moves (bug fix)
    • DuplicateMap now support NaN (it would raise an assertion error before)
    • DuplicateMap no longer test with identical but uses _looseIdentical
  • Improve performance (marginally): before this change we would check for re-insertion when value are not indentical(), now we only check after values are not _looseIdentical(). The perf impact occurs only where we have two Strings that are == but not identical or two NaN at the same index.

@vicb vicb added this to the 0.14.0 milestone Jun 25, 2014
vicb added a commit that referenced this pull request Jul 23, 2014
vicb added a commit that referenced this pull request Jul 23, 2014
@vicb vicb closed this in f01e286 Jul 24, 2014
vicb added a commit that referenced this pull request Jul 24, 2014
vicb added a commit that referenced this pull request Jul 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

[dccd] NaN moves
2 participants