This repository was archived by the owner on Feb 22, 2018. It is now read-only.
fix(WatchGroup): Handle watching on elements of an array correctly. #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvuksano
changed the title
|
@chirayuk Could you review this PR? |
|
@chirayuk any feedback? |
|
Added a comment on the original issue #1046 (comment). (Sorry I missed the github PR notifications completely.) |
| describe('nested watching', () { | ||
| it('should not error when the first item is being watched and it is removed', () { | ||
| element = compile( | ||
| '<ul>' |
There was a problem hiding this comment.
You could make all of these raw string, (i.e. r'foo' instead of 'foo') and then you don't need to escape the "$" for "$index" in the string.
|
Looks good. Thanks. |
|
Merged as 8c271f7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1046