This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Misc minor changes #1061
Closed
Misc minor changes #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add some doc, - Add types, - Make AnnotationsMap._map private, - Simplify AnnotationsMap.annotationsFor
- Make _fieldMetadataCache a static final member, - Simplify some code & make some methods private, - Add docs
|
Could you rebase this on master, to make the merge easier? |
vicb
added a commit
to vicb/angular.dart
that referenced
this pull request
Jul 31, 2014
vicb
added a commit
to vicb/angular.dart
that referenced
this pull request
Jul 31, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Aug 7, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbdeboer could you please review this PR when you have time (low priority).
It's composed of multiple little commit to ease cherry-picking (/rejecting) some if needed - the second commit is style change only.
Check the commit comment for detailed information.