This repository was archived by the owner on Feb 22, 2018. It is now read-only.
feat(date): Use localized patterns for shorthand format #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(Intl.withLocale('fr', () => date(noon, "medium"))). | ||
| toEqual('sept. 3, 2010 12:05:08 PM'); | ||
| toEqual('3 sept. 2010 12:05:08'); |
There was a problem hiding this comment.
This one is definitely right for France
|
@naomiblack Could you review this change? |
|
@naomiblack I have updated the PR to use "# Usage" as "# Example" like other formatters. The PR is ready for review :) |
|
Thanks Vic! Looks good. I've sent it to the presubmit queue. |
|
merged fb1bcf4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1019
/cc @naomiblack