Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

[Q] Naming classes #902

Closed
vicb opened this issue Apr 15, 2014 · 2 comments
Closed

[Q] Naming classes #902

vicb opened this issue Apr 15, 2014 · 2 comments
Milestone
0.10.0

Comments

@vicb
Copy link
Contributor

vicb commented Apr 15, 2014

Some abstract classes (ie AbstractNgAnnotation) have an Abstract prefix while some don't (ie AnnotationMap).

I am in favor of dropping the Abstract prefix, what do you think ?

should we keep a maker I would rather be in favor of an Interface suffix
@zoechi
Copy link
Contributor

zoechi commented Apr 16, 2014

I found that prefix weird too. I think the name itself is to important to be obscured by a prefix. A Base or Interface or whatever suffix is a better solution. Abstract is also redundant because the class has the abstract keyword. Interface/Base is more about its purpose.

@vicb
Copy link
Contributor Author

vicb commented Apr 16, 2014

I think @mhevery has been working on renaming class (seen on TravisCI). This should probably be closed soon. Let's see.

@mhevery mhevery added this to the 0.10.0 milestone Apr 16, 2014
mhevery added a commit that referenced this issue Apr 17, 2014
@mhevery
fix: More consistent type naming
5c4e0d8 
Closes #902

BREAKING CHANGE:
  - Concepts:
    - Filter                        -> Formatter

  - import:
    - angular/directive/ng_a.dart   -> angular/directive/a_href.dart
    - angular/filter/currency.dart  -> angular/formatter/currency.dart
    - angular/filter/date.dart      -> angular/formatter/date.dart
    - angular/filter/filter.dart    -> angular/formatter/filter.dart
    - angular/filter/json.dart      -> angular/formatter/json.dart
    - angular/filter/limit_to.dart  -> angular/formatter/limit_to.dart
    - angular/filter/lowercase.dart -> angular/formatter/lowercase.dart
    - angular/filter/module.dart    -> angular/formatter/module.dart
    - angular/filter/number.dart    -> angular/formatter/number.dart
    - angular/filter/order_by.dart  -> angular/formatter/order_by.dart
    - angular/filter/stringify.dart -> angular/formatter/stringify.dart
    - angular/filter/uppercase.dart -> angular/formatter/uppercase.dart

  - Types:
    - NgA                           -> AHref
    - NgAttachAware                 -> AttachAware
    - NgDetachAware                 -> DetachAware
    - NgShadowRootAware             -> ShadowRootAware
    - NgFilter                      -> Formatter
    - NgInjectableService           -> Injectable
    - AbstractNgAnnotation          -> Directive
    - AbstractNgFieldAnnotation     -> DirectiveAnnotation
    - NgComponent                   -> Component
    - NgController                  -> Controller
    - NgDirective                   -> Decorator
    - NgAnimate                     -> Animate
    - NgZone                        -> VmTurnZone
    - NgAnimationModule             -> AnimationModule
    - NgCoreModule                  -> CoreModule
    - NgCoreDomModule               -> CoreDomModule
    - NgAnimationDirective          -> NgAnimation
    - NgAnimationChildrenDirective  -> NgAnimationChildren
    - FilterMap                     -> FormatterMap
    - NgAttrMustacheDirective       -> AttrMustache
    - NgTextMustacheDirective       -> TextMustache

  - Constants
    - NgDirective.LOCAL_VISIBILITY           -> Directive.LOCAL_VISIBILITY
    - NgDirective.CHILDREN_VISIBILITY        -> Directive.CHILDREN_VISIBILITY
    - NgDirective.DIRECT_CHILDREN_VISIBILITY -> Directive.DIRECT_CHILDREN_VISIBILITY
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
0.10.0
Development

No branches or pull requests
3 participants
@mhevery @vicb @zoechi