List element update not detected #757

chalin · 2014-03-18T18:43:17Z

I am having a problem with list updates not being detected. The simplest example I could think of is given below. If you click on the list[0]=9 button, nothing happens:

Click on Add to list and then the 9 value appears along with the new list element.

This was run on HEAD (5b70fcc).

<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>List update not working</title>
</head>
<body>
  <p>list = {{ list }} of length {{ list.length }}</p>

  <button ng-click='list[0]=9'>list[0] = 9</button>
  <button ng-click='list.add(list.length)'>Add to list</button>

  <script type="application/dart">
  import 'package:angular/angular.dart';
  void main() { ngBootstrap(module: new Module()..type(MyController)); }

  @NgController(selector: 'body', publishAs: 'ctrl')
  class MyController {
    MyController(Scope scope) { scope.context['list'] = [0,1,2]; }
  }
  </script>
  <script src="packages/browser/dart.js"></script>
</body>
</html>

Here is a scope_spec.dart test that illustrates the failure:

      iit('should watch list elt update', (Logger logger, Map context, RootScope rootScope) {
        context['list'] = [true, 2, 'abc'];
        rootScope.watch('list', (value, _) => logger(value));
        rootScope.digest();
        expect(logger).toEqual([[true, 2, 'abc']]);
        logger.clear();
        context['list'][2] = 'def';
        rootScope.digest();
        expect(logger).toEqual([[true, 2, 'def']]);
      });

The text was updated successfully, but these errors were encountered:

vicb · 2014-03-18T18:48:25Z

@chalin I think there is a duplicate either in this tracker or on the ml. Could you please find it and reference it here. Thanks.

chalin · 2014-03-18T18:50:27Z

I searched the tracker before opening this one and did not find it (searched for anything related to 'list') ... because I also have the vague impression of seeing something like this being reported.

vicb · 2014-03-18T18:53:38Z

https://groups.google.com/forum/#!topic/angular-dart/v_t2RUz9lrU ?

chalin · 2014-03-18T19:07:04Z

In the post the complaint was that list update was not detected, but that works in my example. On the other hand, individual element update does not. In both cases of my example (list[0] = 9 and Add to list) the identity of the list is not changed, so why is the behavior different? Shouldn't the list change detection behave the same for both?

vicb · 2014-03-18T22:24:21Z

to me it looks like a duplicate, ie the identity is not change when setting [0]
When list.length changes, the whole text is re-evaluated.
you should try list = {{ list }} of length {{ list.length }}

…and methods Closes dart-archive#359, dart-archive#394, dart-archive#397, dart-archive#757. Relates to dart-archive#772, dart-archive#773.

… to observe lists and maps Closes dart-archive#359, dart-archive#394, dart-archive#397, dart-archive#757. Relates to dart-archive#772, dart-archive#773.

chalin mentioned this issue Mar 20, 2014

[WIP] feat(filters): add filters in support of pure fields and methods, and to observe lists and maps #771

Closed

chalin closed this as completed Mar 20, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

List element update not detected #757

List element update not detected #757

chalin commented Mar 18, 2014

vicb commented Mar 18, 2014

chalin commented Mar 18, 2014

vicb commented Mar 18, 2014

chalin commented Mar 18, 2014

vicb commented Mar 18, 2014

List element update not detected #757

List element update not detected #757

Comments

chalin commented Mar 18, 2014

vicb commented Mar 18, 2014

chalin commented Mar 18, 2014

vicb commented Mar 18, 2014

chalin commented Mar 18, 2014

vicb commented Mar 18, 2014