Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Routing should use ViewPort #704

Closed
codelogic opened this issue Mar 11, 2014 · 6 comments · Fixed by #910
Closed

Routing should use ViewPort #704

codelogic opened this issue Mar 11, 2014 · 6 comments · Fixed by #910
Milestone
0.15.0

Comments

@codelogic
Copy link
Contributor

No description provided.

@codelogic codelogic self-assigned this Mar 11, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Mar 13, 2014
@vicb
feature(routing): make routing use ViewPort
19cff6f 
closes dart-archive#704
@vicb
Copy link
Contributor

vicb commented Mar 13, 2014

@codelogic I've just seen that you were "assigned" to this, do this mean that you've started working on it ?
I think it would be preferable to add an issue comment in such a case (only repo owners can set assignee).

I have a PR under test for this

vicb added a commit to vicb/angular.dart that referenced this issue Mar 13, 2014
@vicb
feature(routing): make routing use ViewPort
0e22067 
closes dart-archive#704
@vicb
Copy link
Contributor

vicb commented Mar 13, 2014

my code is at vicb/angular.dart@master...20140313-routingViewPort, I need to work on the tests

@codelogic codelogic removed their assignment Mar 29, 2014
@mhevery mhevery added this to the 0.9.11 milestone Apr 9, 2014
@mhevery
Copy link
Contributor

mhevery commented Apr 9, 2014

@vicb any update on this? I think you are the new owner of this.

@vicb vicb mentioned this issue Apr 16, 2014
Merged
2 tasks
@vicb vicb modified the milestones: 0.10.0, 0.9.11 Apr 16, 2014
@mhevery mhevery modified the milestones: 0.12.0, 0.10.0 Apr 17, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Apr 23, 2014
@vicb
refactor(NgView): Make use of the ViewPort
ed40de4 
Closes dart-archive#704
vicb added a commit that referenced this issue Apr 30, 2014
@vicb @jbdeboer
refactor(NgView): Make use of the ViewPort
7fb26e5 
Closes #704
@vicb
Copy link
Contributor

vicb commented May 2, 2014

Reopening this, rationale in #991

@vicb vicb reopened this May 2, 2014
@vicb vicb changed the title Routing should use BlockHole Routing should use ViewPort May 2, 2014
@vicb vicb modified the milestones: 0.12.0, 0.11.0 May 8, 2014
@chirayuk chirayuk modified the milestones: 0.13.0, 0.12.0 Jun 3, 2014
@vsavkin vsavkin modified the milestones: 0.14.0, 0.13.0 Jul 24, 2014
@rkirov rkirov modified the milestones: 0.14.0, 0.15.0 Aug 22, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Sep 23, 2014
@vicb
refactor(NgView): Use the ViewPort
0aac7bb 
fixes dart-archive#704
@mehmetf
Copy link
Contributor

mehmetf commented Sep 29, 2014

I have seen a couple of pull requests for this which got withdrawn. Is there a fundamental design issue? If so, is it likely to be resolved?

@vicb
Copy link
Contributor

vicb commented Sep 29, 2014

@mehmetf yep. This is something that can not be supported with the current design: views are nested and child views need to have a reference to their parent. This something that is not currently possible because a view will gets compiled to an anchor (an html comment) which does not support children.
There is no plan to support short term.

@vicb vicb closed this as completed Sep 29, 2014
@mehmetf mehmetf mentioned this issue Sep 30, 2014
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

refactor(NgView): Make use of the ViewPort vicb/angular.dart
7 participants
@vsavkin @chirayuk @rkirov @mhevery @vicb @codelogic @mehmetf