Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Convert bash files to dart files. #482

Open
bgourlie opened this issue Jan 31, 2014 · 10 comments
Open

Convert bash files to dart files. #482

bgourlie opened this issue Jan 31, 2014 · 10 comments

Comments

@bgourlie
Copy link
Contributor

Even with minGW, I cannot get the tests to run on Windows. pub, for example, fails because it is a windows batch script. mktemp also fails. Something platform agnostic would be nice.

@jbdeboer
Copy link
Contributor

jbdeboer commented Feb 4, 2014

Is the problem here that "pub" doesn't run, or that our ./run_tests.sh script is incompatible?

If it is the latter, we just need a little love from a Windows expert.

@bgourlie
Copy link
Contributor Author

bgourlie commented Feb 4, 2014

Well, bash scripts won't run out-of-the-box on Windows, so that sucks to begin with. To answer your question, I don't know exactly what the problem is with running tests using mingw, other than it's attempting to execute a windows batch script from within a POSIX environment, which naturally doesn't seem like something that would work (although I'm not saying it's impossible, I really don't know).

Generally speaking, I think the problem is that using bash scripts makes Windows a second class citizen for hacking dart projects. At the very least, it means jumping through a bunch of hoops. It's a safe assumption that anyone hacking on this has dart installed, so it makes sense to use it for ancillary scripts.

@bgourlie
Copy link
Contributor Author

bgourlie commented Feb 4, 2014

I should also mention another bug related to running tests on windows in case anyone is trying to reproduce the above errors, see https://code.google.com/p/dart/issues/detail?id=16264. This is an SDK bug and not an issue with how the tests are written, but has to be worked around by commenting out the offending line of code.

@chalin
Copy link
Contributor

chalin commented Feb 5, 2014

For what it's worth: in the JML project we did multi-platform development for years and had scripts running smoothly under Windows, MacOS and Linux. Mind you that, under Windows, I used Cygwin, and it worked very nicely.

@mhevery
Copy link
Contributor

mhevery commented Mar 7, 2014

Rewriting the scripts in Dart sounds like a good idea. Do would anyone be willing to do that?

@johnvcoleman
Copy link
Contributor

For the love of all that is holy, yes. I'll take it on. Please? :-)

-----Original Message-----
From: "Miško Hevery" [email protected]
Sent: ‎3/‎7/‎2014 10:02 AM
To: "angular/angular.dart" [email protected]
Subject: Re: [angular.dart] Convert bash files to dart files. (#482)

Rewriting the scripts in Dart sounds like a good idea. Do would anyone be willing to do that?

Reply to this email directly or view it on GitHub.

@chalin
Copy link
Contributor

chalin commented Mar 19, 2014

@johnvcoleman, is the work you are doing covering the build process on Travis or on a developer's local machine (#547) or both?

@johnvcoleman
Copy link
Contributor

I see no reason why we can't solve both with the Hop library. Should be able to distill both use cases down to their elemental tasks, then "chain" those tasks together into the sequence we want using addChainedTask(). I was trying to find your issue earlier so I could reference it, but I got distracted.

@chalin
Copy link
Contributor

chalin commented Mar 19, 2014

I am used to makefiles but am looking forward to see how hop works. It will be nice if we can define an equivalent of a "make clean" too.

@johnvcoleman
Copy link
Contributor

Agreed. I'll add that to the list.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

5 participants