Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

+6%: Component Factory should do much less work #1107

Open
jbdeboer opened this issue Jun 4, 2014 · 3 comments
Open

+6%: Component Factory should do much less work #1107

jbdeboer opened this issue Jun 4, 2014 · 3 comments
Assignees
@jbdeboer
Labels
type: perf
Milestone
post v1.0

Comments

@jbdeboer
Copy link
Contributor

jbdeboer commented Jun 4, 2014

The style element and view factory should be precomputed in the Compiler

This will allow us to remove all of the global injected services and most of the logic.

I estimate a 10-15% speed up in component creation.
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
perf(view cache): Avoid http.get
7759d87 
This change makes templateUrl component creation 100% faster.

It is a stop-gap until dart-archive#1107 is fixed.
@jbdeboer jbdeboer mentioned this issue Jun 4, 2014
Merged
jbdeboer added a commit that referenced this issue Jun 4, 2014
@jbdeboer
perf(view cache): Avoid http.get
f593fe9 
This change makes templateUrl component creation 100% faster.

It is a stop-gap until #1107 is fixed.

Closes #1108
jbdeboer added a commit that referenced this issue Jun 4, 2014
@jbdeboer
perf(view cache): Avoid http.get
db72a4f 
This change makes templateUrl component creation 100% faster.

It is a stop-gap until #1107 is fixed.

Closes #1108
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
perf(view cache): Avoid http.get
56625d7 
This change makes templateUrl component creation 100% faster.

It is a stop-gap until dart-archive#1107 is fixed.
@jbdeboer
Copy link
Contributor Author

jbdeboer commented Jun 5, 2014

If anybody would like to start work on this, please ping me for details.

@jbdeboer jbdeboer mentioned this issue Jun 5, 2014
Open
@jbdeboer jbdeboer self-assigned this Jun 7, 2014
@jbdeboer
Copy link
Contributor Author

jbdeboer commented Jun 7, 2014

I'll take a short jab at this issue

@jbdeboer
Copy link
Contributor Author

jbdeboer commented Jun 8, 2014

My work is in jbdeboer:componentfactoryfactory

I see a ~6% performance improvement (after the DI 1.1.0 is in and the ElementProbe is removed) since we aren't making as many injector.get calls

@jbdeboer jbdeboer changed the title Perf: Component Factory should do much less work Perf: +2%: Component Factory should do much less work Jun 8, 2014
@jbdeboer jbdeboer changed the title Perf: +2%: Component Factory should do much less work +6%: Component Factory should do much less work Jun 8, 2014
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
perf(view cache): Avoid http.get
d64f5cb 
This change makes templateUrl component creation 100% faster.

It is a stop-gap until dart-archive#1107 is fixed.

Closes dart-archive#1108
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
perf(view cache): Avoid http.get
fc4a7ae 
This change makes templateUrl component creation 100% faster.

It is a stop-gap until dart-archive#1107 is fixed.

Closes dart-archive#1108
@naomiblack naomiblack modified the milestone: post v1.0 Oct 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbdeboer jbdeboer

Labels
type: perf
Milestone
post v1.0
Development

No branches or pull requests
2 participants
@jbdeboer @naomiblack