We should also run the test in non-checked mode

[vicb]

We run quite some code in assert()s

It would be better to also the tests in non-checked to make sure everything is also fine.

See #1097 (comment) for an example of a non-checked mode failure only

[jbdeboer]

+1

[vsavkin]

I'm working on it

[vsavkin]

Do you think testing non-checked mode for Dart only is OK? Or should we cover both Dart and Dart2JS?

[mvuksano]

Once you compile dart into JavaScript there's no more checked mode. Checked
mode is only aplickable to dart.
On 19/06/2014 1:29 AM, "Victor Savkin" [email protected] wrote:

Do you think testing non-checked mode for Dart only is OK? Or should we
cover both Dart and Dart2JS?

—
Reply to this email directly or view it on GitHub
#1103 (comment)
.

[vsavkin]

@markovuksanovic you are right that after compilation there is no more checked mode. But you can still include/omit runtime assertions when compiling a Dart program to JS, which somewhat corresponds to running your program in checked/non-checked mode. And it looks like right when running Angular specs we always include those assertions.

[vicb]

As discussed with Victor, testing Dart only seems a good option:

• it is fast,
• testing generated JS code is mostly testing the dart2js compiler, not the our code.

But if we expect the majority of users to use the JS version, it might also be a good idea to test it...

[vmendi]

Please run the tests in JS too. I've been fighting with #1097 (comment) for a day until I found this. After 2 months of experience with dart + angulardart, we've found that we constantly need to test the JS version because from time to time there are differences, crashes mostly.

BTW, another hard one was this:
http://stackoverflow.com/questions/23856072/dart-nosuchmethoderror-cannot-call-getdata-config-getdata-is-not-a-functi/23890496#23890496

[mvuksano]

We do run tests in JS. Tests are run in dart and JS for both stable and dev
dart SDK.
On 28/06/2014 7:47 PM, "vmendi" [email protected] wrote:

Please run the tests in JS too. I've been fighting with #1097 (comment)
#1097 (comment)
for a day until I found this. After 2 months of experience with dart +
angulardart, we've found that we constantly need to test the JS version
because from time to time there are differences, crashes mostly.

BTW, another hard one was this:

http://stackoverflow.com/questions/23856072/dart-nosuchmethoderror-cannot-call-getdata-config-getdata-is-not-a-functi/23890496#23890496

—
Reply to this email directly or view it on GitHub
#1103 (comment)
.