This repository was archived by the owner on Feb 22, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
[chap2] tweaks to match updates to tutorial prose #70
Merged
kwalrath
merged 3 commits into
dart-archive:master
from
chalin:patch-chap2-comp-class-updates
Feb 11, 2014
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,9 +7,9 @@ import 'package:perf_api/perf_api.dart'; | |
@MirrorsUsed(targets: const['recipe_book'], override: '*') | ||
import 'dart:mirrors'; | ||
|
||
/* Use the NgController annotation to indicate that this class is an | ||
* Angular Controller. The compiler will instantiate the controller if | ||
* it finds it in the DOM. | ||
/* Use the @NgController annotation to indicate that this class is an | ||
* Angular Controller. Angular will instantiate the controller if | ||
* it finds an element matching it's selector in the DOM. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's -> its |
||
* | ||
* The selector field defines the CSS selector that will trigger the | ||
* controller. It can be any valid CSS selector which does not cross | ||
|
@@ -82,6 +82,6 @@ class MyAppModule extends Module { | |
} | ||
} | ||
|
||
main() { | ||
void main() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tend not to include the "void", but if it's in the chapter's text (and used in other chapters), I guess we should include it here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For the record (as I had mentioned in response to another comment): the Dart Editor now declares I am fixing the other issues and will commit soon. |
||
ngBootstrap(module: new MyAppModule()); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Controller -> controller