comment nit

[adam-singer]

@kwalrath I found that comment confusing in regards to the code with profiling enabled. Actually had to look up "comment out" :)
http://english.stackexchange.com/questions/33483/when-i-say-comment-out-does-it-mean-to-uncomment-something-or-comment-it

[kwalrath]

Hey, Adam! I think "Comment out" is actually the right thing to say there... that profiling is disabled unless that line is rendered inert. That said, I've never understood that code.

@traceypowersg is that right? People do find this line confusing. Would it be OK to delete it (perhaps to add & explain it later) or should we just explain it in Chapter 2? Should this line of code be in every app until you're ready to do profiling? (Have you profiled this app?) Thx.

[traceypowersg]

Here's what that should really say:

The default Profiler that is bound with Dependency Injection is very noisy,
and gives you all sorts of useful Profiling information about the Router,
which you may find useful, or annoying, depending on what you're trying to
do.

This line binds a quiet Profiler, replacing the Noisy default Profiler.

On Fri, Feb 7, 2014 at 10:44 AM, Kathy Walrath [email protected]:

Hey, Adam! I think "Comment out" is actually the right thing to say
there... that profiling is disabled unless that line is rendered inert.
That said, I've never understood that code.

@traceypowersg https://github.com/traceypowersg is that right? People
do find this line confusing. Would it be OK to delete it (perhaps to add &
explain it later) or should we just explain it in Chapter 2? Should this
line of code be in every app until you're ready to do profiling? (Have you
profiled this app?) Thx.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/68#issuecomment-34486672
.

[kwalrath]

@financecoding it sounds like you & I should try commenting out that line, just to see what happens.

In any case, are you up for improving the comment?

[traceypowersg]

Try commenting it out and look at the console. It used to be extremely
noisy with Router configuration profiling information. That stuff is very
useful, almost necessary if you're trying to figure out routing. If you're
not, then it just spams your console to the point where you can't find the
messages you're looking for.

But that was months ago, so the profiler stuff could have changed.

On Fri, Feb 7, 2014 at 2:21 PM, Kathy Walrath [email protected]:

@financecoding https://github.com/financeCoding it sounds like you & I
should try commenting out that line, just to see what happens.

In any case, are you up for improving the comment?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/68#issuecomment-34513909
.

[adam-singer]

Commented it out seems to produce the same console output as it not commented out.

[kwalrath]

Would you mind changing the PR (or opening a new one) that deletes the Profiler line?

[adam-singer]

Sure will update or open new by tonight

[adam-singer]

@kwalrath updated with remove profiler

[kwalrath]

@financecoding I don't see this change (removing the profiler line). Did you upload it?

[adam-singer]

hmm, not sure what I must of done.. Let me check out my local git repo

[adam-singer]

fixed up, must of pushed the wrong branch

[kwalrath]

Thanks, Adam!