feat: exposed the build_properties from the CLI
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankeboy36
changed the title
build_properties from the CLI
per1234
reviewed
May 23, 2023
dankeboy36
force-pushed
the
build_properties
branch
from
2fe8107 to
90d107e
Compare
dankeboy36
force-pushed
the
build_properties
branch
4 times, most recently
from
acae985 to
eabe9f6
Compare
dankeboy36
force-pushed
the
build_properties
branch
2 times, most recently
from
681f228 to
58cda48
Compare
dankeboy36
force-pushed
the
build_properties
branch
2 times, most recently
from
d7b5230 to
9bfc0ec
Compare
- keep the state in the memory, - derived API types from the CLI's API, - basic configuration support, - replaced `buildPath` with `compileSummary`, and - updated the readme. Signed-off-by: dankeboy36 <[email protected]>
dankeboy36
force-pushed
the
build_properties
branch
from
9bfc0ec to
8894176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
board.txtvia the CLI'sboardDetails#buildProperties. This is a must to be able to calculate tools' paths. See the related PR: feat: expose the Arduino state to VS Code extensions arduino/arduino-ide#2071 (comment)VID/PID. It's a flawed API in Arduino IDE 2.x, and the incorrect behavior was fixed here: https://github.com/arduino/arduino-ide/pull/1803/files#diff-5d1d983d12138bab8eacdceac2ab9894c0392ed723e14bcfa09c9a06d5bbe794L86-R61.buildPathwithcompileSummary, and