Remove restriction on column name

Author: Adrian Teng

arctic/fixtures/arctic.py

@@ -76,7 +76,7 @@ def library(arctic, library_name):
 
 @pytest.fixture(scope="function")
 def bitemporal_library(arctic, library_name):
-    arctic.initialize_library(library_name, m.VERSION_STORE, segment='month')  # TODO: segment=month??
+    arctic.initialize_library(library_name, m.VERSION_STORE, segment='month')
     return BitemporalStore(arctic.get_library(library_name))
 
 

arctic/store/bitemporal_store.py

@@ -78,8 +78,6 @@ def update(self, symbol, data, metadata=None, upsert=True, as_of=None, **kwargs)
         as_of : `datetime.datetime`
             The "insert time". Default to datetime.now()
         """
-        if self.observe_column in data.index.names:
-            raise ValueError("Column {} is not allowed as it is being used by bitemporal store interally.".format(self.observe_column))
         local_tz = mktz()
         if not as_of:
             as_of = dt.now()

tests/integration/store/test_bitemporal_store.py

@@ -44,6 +44,16 @@ def test_read_ts_raw(bitemporal_library):
                                                       2012-11-08 17:06:11.040 |  2015-05-01 |  3.0""", num_index=2))
 
 
+def test_write_ts_with_column_name_same_as_observed_dt_ok(bitemporal_library):
+    ts1 = read_str_as_pandas("""       sample_dt | observed_dt | near
+                         2012-09-08 17:06:11.040 |    2015-1-1 |  1.0
+                         2012-10-08 17:06:11.040 |    2015-1-1 |  2.0
+                         2012-10-09 17:06:11.040 |    2015-1-1 |  2.5
+                         2012-11-08 17:06:11.040 |    2015-1-1 |  3.0""")
+    bitemporal_library.update('spam', ts1)
+    assert_frame_equal(ts1, bitemporal_library.read('spam').data)
+
+
 def test_last_update(bitemporal_library):
     bitemporal_library.update('spam', ts1, as_of=dt(2015, 1, 1))
     bitemporal_library.update('spam', ts1, as_of=dt(2015, 1, 2))

tests/unit/store/test_bitemporal_store.py

@@ -1,8 +1,7 @@
 from datetime import datetime as dt
 
-from mock import create_autospec, sentinel
+from mock import create_autospec
 from pandas.util.testing import assert_frame_equal
-import pytest
 
 from arctic.store.bitemporal_store import BitemporalStore
 from tests.util import read_str_as_pandas
@@ -23,12 +22,3 @@ def test_add_observe_dt_index():
                                2012-10-08 17:06:11.040 | 2001-01-01 |  2.0
                                2012-10-09 17:06:11.040 | 2001-01-01 |  2.5
                                2012-11-08 17:06:11.040 | 2001-01-01 |  3.0""", num_index=2))
-
-
-def test_update_with_observe_column_fails():
-    self = create_autospec(BitemporalStore, observe_column='col_a')
-    with pytest.raises(ValueError) as e:
-        BitemporalStore.update(self, sentinel.symbol, read_str_as_pandas(
-                           """col_b |      col_a | near
-            2012-09-08 17:06:11.040 | 2001-01-01 |  1.0""", num_index=2))
-    assert str(e.value) == "Column col_a is not allowed as it is being used by bitemporal store interally."