Fix column name check

Author: Adrian Teng

arctic/store/bitemporal_store.py

@@ -78,7 +78,7 @@ def update(self, symbol, data, metadata=None, upsert=True, as_of=None, **kwargs)
         as_of : `datetime.datetime`
             The "insert time". Default to datetime.now()
         """
-        if self.observe_column in data:
+        if self.observe_column in data.index.names:
             raise ValueError("Column {} is not allowed as it is being used by bitemporal store interally.".format(self.observe_column))
         local_tz = mktz()
         if not as_of:

tests/unit/store/test_bitemporal_store.py

@@ -1,6 +1,8 @@
 from datetime import datetime as dt
-from mock import create_autospec
+
+from mock import create_autospec, sentinel
 from pandas.util.testing import assert_frame_equal
+import pytest
 
 from arctic.store.bitemporal_store import BitemporalStore
 from tests.util import read_str_as_pandas
@@ -12,12 +14,21 @@
                          2012-10-09 17:06:11.040 |  2.5
                          2012-11-08 17:06:11.040 |  3.0""")
 
+
 def test_add_observe_dt_index():
-    self = create_autospec(BitemporalStore, observe_column='col_a',
-                           sample_column='col_b')
+    self = create_autospec(BitemporalStore, observe_column='col_a')
     assert_frame_equal(BitemporalStore._add_observe_dt_index(self, ts1, as_of=dt(2001, 1, 1)),
-                       read_str_as_pandas("""col_b |      col_a | near
-                           2012-09-08 17:06:11.040 | 2001-01-01 |  1.0
-                           2012-10-08 17:06:11.040 | 2001-01-01 |  2.0
-                           2012-10-09 17:06:11.040 | 2001-01-01 |  2.5
-                           2012-11-08 17:06:11.040 | 2001-01-01 |  3.0""", num_index=2))
+                       read_str_as_pandas("""sample_dt |      col_a | near
+                               2012-09-08 17:06:11.040 | 2001-01-01 |  1.0
+                               2012-10-08 17:06:11.040 | 2001-01-01 |  2.0
+                               2012-10-09 17:06:11.040 | 2001-01-01 |  2.5
+                               2012-11-08 17:06:11.040 | 2001-01-01 |  3.0""", num_index=2))
+
+
+def test_update_with_observe_column_fails():
+    self = create_autospec(BitemporalStore, observe_column='col_a')
+    with pytest.raises(ValueError) as e:
+        BitemporalStore.update(self, sentinel.symbol, read_str_as_pandas(
+                           """col_b |      col_a | near
+            2012-09-08 17:06:11.040 | 2001-01-01 |  1.0""", num_index=2))
+    assert str(e.value) == "Column col_a is not allowed as it is being used by bitemporal store interally."