Skip to content

remove rawgit dependency from the demo #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove rawgit dependency from the demo #284

wants to merge 1 commit into from

Conversation

tuomassalo
Copy link

cdn.rawgit.com was down today, so I couldn't try out the demo - not even by cloning the repo. This PR aims to fix that.

@dalelotts
Copy link
Owner

I don't agree with adding angular-date-time-input as a dependency - perhaps a devDependency would be okay.

How often is rawgit down?

@tuomassalo
Copy link
Author

You're right, devDependency is better.

I don't have stats, but rawgit seems to be down(ish) again.

dalelotts added a commit that referenced this pull request Sep 11, 2016
@dalelotts
style(js,css): Use standard and stylelint for linting js and css
81ef83d 
Use npm standard package to lint js - this is non-configurable and does not allow semicolons.

stylelint lints the css. Also added link to gitter chat the readme file.

Closes #280, #284, #313
@dalelotts
Copy link
Owner

Included in 1.1.0

@dalelotts dalelotts closed this Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuomassalo @dalelotts