Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

feat: Add user configuration for all providers #4

Merged
merged 13 commits into from
Apr 1, 2024

Conversation

dlipovetsky
Copy link

@dlipovetsky dlipovetsky commented Mar 21, 2024

  • Defines a cluster-level variable for defining one or more users
  • Patches bootstrap templates for control plane and worker node pools with user configuration
  • Derives value of CABPK's User.LockPassword

@github-actions github-actions bot added feature and removed feature labels Mar 21, 2024
- Defines a cluster-level variable for defining one or more users
- Patches bootstrap templates for control plane and worker node pools
  with user configuration
@dlipovetsky dlipovetsky requested a review from dkoshkin March 22, 2024 17:00
Copy link
Member

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits but looking good!

dkoshkin
dkoshkin previously approved these changes Mar 27, 2024
Copy link
Collaborator

@dkoshkin dkoshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fix typo in lockPassword logic, and add unit test
Add unit test for empty hashed password
Change Sudo field from pointer to value

The zero value (empty string) is not valid, so the field does not need
to be a pointer.
Explain why we do not validate hashed password input
Explain why we do not validate sudo input
@dlipovetsky
Copy link
Author

I changed the fixup commit messages to make them conform to the precommit linter, then force-pushed.

@dlipovetsky
Copy link
Author

precommit fails because markdownlint complains about line length >= 120 chars in the documentation I wrote.

While maximum line length make sense for a programming language, I think it makes less sense for prose:

  1. The docs are written in a text editor, and almost any editor can automatically wrap lines. I don't want to manually wrap lines the first time, or re-wrap lines as I update prose.
  2. The docs are read in a browser and a text editor. Almost any browser or editor can automatically wrap lines. Manual wrapping can make it more difficult to wrap text automatically for a given viewport size.

I'd like to remove the rule, and eventually revert all docs to automatically wrapped lines.

@dkoshkin
Copy link
Collaborator

I'd like to remove the rule, and eventually revert all docs to automatically wrapped lines.

Thanks, I support this.

@dlipovetsky
Copy link
Author

I'd like to remove the rule, and eventually revert all docs to automatically wrapped lines.

Thanks, I support this.

Thanks, I filed nutanix-cloud-native#480.

@faiq faiq enabled auto-merge April 1, 2024 17:37
@faiq faiq merged commit 9cad889 into d2iq-labs:main Apr 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants