-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add user configuration for all providers #4
Conversation
- Defines a cluster-level variable for defining one or more users - Patches bootstrap templates for control plane and worker node pools with user configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits but looking good!
Address review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Expand comments
Fix typo in lockPassword logic, and add unit test
Add unit test for empty hashed password
Change Sudo field from pointer to value The zero value (empty string) is not valid, so the field does not need to be a pointer.
Make username required
Explain why we do not validate hashed password input
Explain why we do not validate sudo input
Update type comments
Remove errant comment
Add users to the docs site
I changed the fixup commit messages to make them conform to the precommit linter, then force-pushed. |
precommit fails because markdownlint complains about line length >= 120 chars in the documentation I wrote. While maximum line length make sense for a programming language, I think it makes less sense for prose:
I'd like to remove the rule, and eventually revert all docs to automatically wrapped lines. |
Manually wrap lines in doc
Thanks, I support this. |
Thanks, I filed nutanix-cloud-native#480. |
User.LockPassword