This repository was archived by the owner on Apr 11, 2024. It is now read-only.
refactor: use a string type for Nutanix's AdditionalTrustBundle #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakm-ntnx
reviewed
Apr 4, 2024
deepakm-ntnx
reviewed
Apr 4, 2024
pkg/handlers/nutanix/mutation/prismcentralendpoint/tests/generate_patches.go
Show resolved
Hide resolved
dkoshkin
force-pushed
the
dkoshkin/refactor-trust-bundle
branch
from
691c713 to
81a3c9f
Compare
deepakm-ntnx
reviewed
Apr 4, 2024
deepakm-ntnx
approved these changes
Apr 4, 2024
deepakm-ntnx
reviewed
Apr 4, 2024
pkg/handlers/nutanix/mutation/prismcentralendpoint/tests/generate_patches.go
Show resolved
Hide resolved
dkoshkin
force-pushed
the
dkoshkin/refactor-trust-bundle
branch
2 times, most recently
from
826c1c7 to
b26f26d
Compare
Use a string instead of a ConfigMap reference to make it easier for both the handlers to use, and the clients to set in the API.
dkoshkin
force-pushed
the
dkoshkin/refactor-trust-bundle
branch
from
b26f26d to
0d6a9b1
Compare
faiq
approved these changes
Apr 4, 2024
jimmidyson
pushed a commit
that referenced
this pull request
Apr 11, 2024
* refactor: use a string type for Nutanix's AdditionalTrustBundle Use a string instead of a ConfigMap reference to make it easier for both the handlers to use, and the clients to set in the API. * fix: force insecure: false with additionalTrustBundle
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to propose this.
Use a string instead of a ConfigMap reference to make it easier for both the handlers to use without needing to make additional API calls. And the clients needing to know how to create these ConfigMaps.