fix: Replaced hardcoded.nyc_output string to one from config
#332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoidan
added a commit
to akoidan/vue-webpack-typescript
that referenced
this pull request
Nov 7, 2020
…s/code-coverage 3.x they seem to fixed most hardoded things, but `temp-dir` in `.nycrc.json`, so I forked their repo and added pr cypress-io/code-coverage#332 so it can be updated in package.json on next release if this happens tsconfig.json should not have 'sourceMap', seems like cypress adds 'inlineSourceMap' on top of my config which causes `TS5053: Option 'sourceMap' cannot be specified with option 'inlineSourceMap'.` If in future adding this option doesn't cause `yarn test:cypress:run` to fail, it can be restored
|
What's the status of this PR? Any reason not to merge it? |
|
I think this PR is ok to merge, would be nice to have a dedicated example test, but the existing examples seem to still be working |
bahmutov
changed the title
.nyc_output string to one from config.nyc_output string to one from config
|
🎉 This PR is included in version 3.8.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
akoidan
added a commit
to akoidan/vue-webpack-typescript
that referenced
this pull request
Nov 23, 2020
Merged PR cypress-io/code-coverage#332 so updated to main package istead of mine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atm code-coverage doesn't respect nyc config file like
.nycrc.json. So it's impossible to change nyc json coverage object location by using this package.This PR changed location of temp-dir to the one that's specified in config file and if it's absent falls back to hardcoded
.nyc_output