-
Notifications
You must be signed in to change notification settings - Fork 112
Add next.js typescript example #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The one thing I'd like help on and could not get working would be automatic path aliasing. Out of the box, Next.js TS has root-folder path aliases. Additionally, if I define any in the root Ignoring the feature request-y nature of the above. I couldn't get path aliases even explicitly working if they collided with a path alias from the root. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this. You know what you could do in your example README - take a screenshot of the coverage report showing the filenames, similar to https://github.com/bahmutov/next-and-cypress-example#coverage
Any words on path aliases @bahmutov ? As it stands, I'd have to maintain path aliases in 3 different locations if I use Next/Cypress/Jest :( |
No, currently have no idea how to do it
…Sent from my iPhone
On Oct 9, 2020, at 12:24, Kyle Holmberg ***@***.***> wrote:
Any words on path aliases @bahmutov ? As it stands, I'd have to maintain path aliases in 3 different locations if I use Next/Cypress/Jest :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Done! Resolved a few small issues as well. Please note, I had no need for I'l also willing and able to merge this in as a 1st-class solution if you'd like |
What do you mean as 1st class solution?
…Sent from my iPhone
On Oct 9, 2020, at 18:15, Kyle Holmberg ***@***.***> wrote:
Done! Resolved a few small issues as well. Please note, I had no need for cypress/tsconfig.json!
I'l also willing and able to merge this in as a 1st-class solution if you'd like
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
hahaha sorry.. i mean it doesn't have to be external (tied to my github account). We could put into the official examples folder of this repo |
🎉 This PR is included in version 3.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
See: bahmutov/next-and-cypress-example#104