Skip to content

feat: support .vue files coverage #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion cypress/integration/spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
// https://on.cypress.io/intelligent-code-completion
/// <reference types="Cypress" />

import {add} from '../unit'
import { add } from '../unit'
const { fixSourcePathes } = require('../../utils')

context('Page test', () => {
beforeEach(() => {
Expand All @@ -28,4 +29,33 @@ context('Unit tests', () => {
it('concatenates strings', () => {
expect(add('foo', 'Bar')).to.equal('fooBar')
})

it('fixes webpack loader source-map path', () => {
const coverage = {
'/folder/module.js': {
inputSourceMap: {
sources: ['/folder/module.js']
}
},
'/folder/component.vue': {
inputSourceMap: {
sources: [
'/folder/node_modules/cache-loader/dist/cjs.js??ref--0-0!/folder/node_modules/vue-loader/lib/index.js??vue-loader-options!/folder/component.vue?vue&type=script&lang=ts&'
]
}
},
'/folder/module-without-sourcemap.js': {
path: '/folder/module-without-sourcemap.js'
}
}

fixSourcePathes(coverage)

expect(coverage['/folder/module.js'].inputSourceMap.sources)
.to.deep.equal(['/folder/module.js'])
expect(coverage['/folder/component.vue'].inputSourceMap.sources)
.to.deep.equal(['/folder/component.vue'])
expect(coverage['/folder/module-without-sourcemap.js'].path)
.to.eq('/folder/module-without-sourcemap.js')
})
})
2 changes: 2 additions & 0 deletions task.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const { join } = require('path')
const { existsSync, mkdirSync, readFileSync, writeFileSync } = require('fs')
const execa = require('execa')
const debug = require('debug')('code-coverage')
const { fixSourcePathes } = require('./utils')

// these are standard folder and file names used by NYC tools
const outputFolder = '.nyc_output'
Expand Down Expand Up @@ -49,6 +50,7 @@ module.exports = {
* with previously collected coverage.
*/
combineCoverage (coverage) {
fixSourcePathes(coverage)
const previous = existsSync(nycFilename)
? JSON.parse(readFileSync(nycFilename))
: istanbul.createCoverageMap({})
Expand Down
17 changes: 17 additions & 0 deletions utils.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
module.exports = {
/**
* Remove potential Webpack loaders string and query parameters from sourcemap path
*/
fixSourcePathes (coverage) {
Object.keys(coverage).forEach(file => {
const sourcemap = coverage[file].inputSourceMap
if (!sourcemap) return
sourcemap.sources = sourcemap.sources.map(source => {
let cleaned = source
if (cleaned.includes('!')) cleaned = cleaned.split('!').pop()
if (cleaned.includes('?')) cleaned = cleaned.split('?').shift()
return cleaned
})
})
}
}