Skip to content

scala 2.13 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2019
Merged

scala 2.13 #18

merged 2 commits into from
Jun 25, 2019

Conversation

lewismj
Copy link
Contributor

@lewismj lewismj commented Jun 25, 2019

Hopefully, this fixes .travis file and tests.

In this PR I've added the minimal set of code changes for a Scala 2.13 build.

Since 2.13, the import 'scala.jdk.CollectionConverters' is preferred for Java <=> Scala collection conversion.

However, I thought it better to leave warning, rather than change the build (having separate code directory for Scala versions) - just for one import statement: 2.14 & 3 will use the 2.13 convention and better to just change the import statement in a future version. If you did want separate sources, I think this would be a good first step anyway.

@glibas glibas self-requested a review June 25, 2019 08:59
@glibas glibas self-assigned this Jun 25, 2019
@glibas
Copy link
Member

glibas commented Jun 25, 2019

Hi @lewismj , thank you for your contribution. Looks good to me. Merging.

@glibas glibas merged commit f6c9af5 into cucumber:master Jun 25, 2019
@aslakhellesoy
Copy link
Contributor

Hi @lewismj,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@glibas glibas mentioned this pull request Jun 25, 2019
@lewismj
Copy link
Contributor Author

lewismj commented Jun 25, 2019

Hi @aslakhellesoy,

Thanks very much, I've been maintaining an SBT cucumber plugin, so would be great to delve a little deeper into cucumber itself.

@mpkorstanje
Copy link
Contributor

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants