Skip to content

Fix inappropriate modification of animation keywords #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2018

Conversation

kogai
Copy link
Contributor

@kogai kogai commented Dec 20, 2018

It seems there is a case which handling animation-keywords as local-identifier incorrectly.

Originally, the issue reported at webpack-contrib/css-loader#872

@codecov-io
Copy link

codecov-io commented Dec 20, 2018

Codecov Report

Merging #5 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   99.56%   99.57%   +<.01%     
==========================================
  Files           2        2              
  Lines         232      234       +2     
  Branches       65       66       +1     
==========================================
+ Hits          231      233       +2     
  Misses          1        1
Impacted Files Coverage Δ
test.js 100% <ø> (ø) ⬆️
index.js 99.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bb518...bb4bec6. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, i think we need test from issue:

animation: slide-right 300ms forwards ease-out, fade-in 300ms forwards ease-out;

@kogai
Copy link
Contributor Author

kogai commented Dec 21, 2018

@evilebottnawi OK, I've adjusted the spec to includes some local variables like the issue 👉 bb4bec6 .

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!

@alexander-akait alexander-akait merged commit e66cb3c into css-modules:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants