Skip to content

test glob-ignores branch as py pkg #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented May 6, 2024

to test glob-ignores branch in cpp-linter/cpp-linter#103

@2bndy5 2bndy5 closed this May 6, 2024
@2bndy5 2bndy5 deleted the test-glob-ignores branch May 6, 2024 22:26
@shenxianpeng
Copy link
Collaborator

I am not sure if you need to update .github/workflows/cpp-lint-package.yml with --ignore-tidy and/or --ignore-format options for testing this new feature.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented May 7, 2024

Good catch! I tested it locally on a another repo of mine and everything was fine. I re-test again with those new options.

Copy link

github-actions bot commented May 14, 2024

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 1 file(s) not formatted
  • src/demo.cpp
clang-tidy reports: 6 concern(s)

Have any feedback or feature suggestions? Share it here.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented May 14, 2024

The new CLI options seem to be working as expected.

I don't expect any edge cases because the file filtering algorithm used for each clang tool is the same algorithm used for filtering files for both tools. The glob pattern support may might instigate some issues about user-expected behavior. But the new unit tests covering glob pattern support inspire much confidence.

@2bndy5 2bndy5 closed this Jun 4, 2024
@2bndy5 2bndy5 deleted the test-glob-ignores branch June 4, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants