cpp-linter · 2bndy5 · Jan 6, 2024 · Jan 6, 2024 · Jan 6, 2024 · Jan 7, 2024
diff --git a/.github/workflows/cpp-lint-package.yml b/.github/workflows/cpp-lint-package.yml
@@ -7,16 +7,17 @@ on:
         description: 'which branch to test'
         default: 'main'
         required: true
+  pull_request:
 
 jobs:
   cpp-linter:
     runs-on: windows-latest
 
     strategy:
       matrix:
-        clang-version: ['7', '8', '9','10', '11', '12', '13', '14', '15', '16', '17']
+        clang-version: ['10', '11', '12', '13', '14', '15', '16', '17']
         repo: ['cpp-linter/cpp-linter']
-        branch: ['${{ inputs.branch }}']
+        branch: ['pr-review-suggestions']
       fail-fast: false
 
     steps:
@@ -62,10 +63,12 @@ jobs:
           -i=build 
           -p=build 
           -V=${{ runner.temp }}/llvm 
-          -f=false 
           --extra-arg="-std=c++14 -Wall" 
-          --thread-comments=${{ matrix.clang-version == '12' }} 
-          -a=${{ matrix.clang-version == '12' }}
+          --file-annotations=false
+          --lines-changed-only=false
+          --thread-comments=${{ matrix.clang-version == '16' }} 
+          --tidy-review=${{ matrix.clang-version == '16' }}
+          --format-review=${{ matrix.clang-version == '16' }}
 
       - name: Fail fast?!
         if: steps.linter.outputs.checks-failed > 0

diff --git a/src/demo.cpp b/src/demo.cpp
@@ -1,17 +1,18 @@
 /** This is a very ugly test code (doomed to fail linting) */
 #include "demo.hpp"
-#include <cstdio>
-#include <cstddef>
+#include <stdio.h>
-#include <stdio.h>
+#include <cstdio>
-#include <stdio.h>
+#include <cstdio>
 
-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }
 
-
+int main()
+{
-
+auto main() -> int
+{
-
+int main()
+{
-
+auto main() -> int
+{
-int main()
-{
-    for (;;)
-        break;
+
+
+int main(){
+
+    for (;;) break;
+
-
-
-int main(){
-
-    for (;;) break;
+    for (;;)
+        break;
-
-
-int main(){
-
-    for (;;) break;
+    for (;;) {
+        break;
+    }
-
-
-int main(){
-
-    for (;;) break;
+    for (;;)
+        break;
-
-
-int main(){
-
-    for (;;) break;
+    for (;;) {
+        break;
+    }
 
     printf("Hello world!\n");
-
-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }
-
-int main()
-{
-    for (;;)
-        break;
-
-
-int main(){
-
-    for (;;) break;
-
-
-    printf("Hello world!\n");
+
+int main()
+{
+
+    for (;;)
+        break;
+
-#include "demo.hpp"
-#include <cstdio>
-#include <cstddef>
-#include <stdio.h>
-
-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }
-
-int main()
-{
-    for (;;)
-        break;
-
-
-int main(){
-
-    for (;;) break;
-
-
-    printf("Hello world!\n");
+#include "demo.hpp"
+#include <cstdio>
+
+auto main() -> int
+{
+
+    for (;;) {
+        break;
+    }
+
-
-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }
-
-int main()
-{
-    for (;;)
-        break;
-
-
-int main(){
-
-    for (;;) break;
-
-
-    printf("Hello world!\n");
+
+int main()
+{
+
+    for (;;)
+        break;
+
-#include "demo.hpp"
-#include <cstdio>
-#include <cstddef>
-#include <stdio.h>
-
-// using size_t from cstddef
-size_t dummyFunc(size_t i) { return i; }
-
-int main()
-{
-    for (;;)
-        break;
-
-
-int main(){
-
-    for (;;) break;
-
-
-    printf("Hello world!\n");
+#include "demo.hpp"
+#include <cstdio>
+
+auto main() -> int
+{
+
+    for (;;) {
+        break;
+    }
+
 
-    return 0;
-}
+
+
+
+    return 0;}
-
-
-
-    return 0;}
+    return 0;
+}
-    return 0;}
+    return 0;
+}
-
-
-
-    return 0;}
+    return 0;
+}
-    return 0;}
+    return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
@@ -5,12 +5,10 @@
 class Dummy {
     char* useless;
     int numb;
+    Dummy() :numb(0), useless("\0"){}
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
-    char* useless;
-    int numb;
-    Dummy() :numb(0), useless("\0"){}
+    char* useless { "\0" };
+    int numb { 0 };
+    Dummy() { }
 
     public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
+    void *not_useful(char *str){useless = str;}
-    Dummy() :numb(0), useless("\0"){}
-
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
+
+public:
+    void* not_useful(char* str) { useless = str; }
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }
-    Dummy() :numb(0), useless("\0"){}
-
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
+    Dummy()
+        : numb(0)
+        , useless("\0")
+    {
+    }
+
+public:
+    void* not_useful(char* str) { useless = str; }
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
+public:
+    auto not_useful(char* str) -> void* { useless = str; }
 };
 
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
-};
+    public:
+        auto not_useful(char* str) -> void* { useless = str; }
+};
-    public:
-    void *not_usefull(char *str){
-        useless = str;
-        return 0;
-    }
-    void *not_useful(char *str){useless = str;}
-};
+    public:
+        auto not_useful(char* str) -> void* { useless = str; }
+};
 
@@ -28,14 +26,11 @@ class Dummy {
 
 
 
-
-
-
-
 
 
 struct LongDiff
 {
+
     long diff;
 
 };