Skip to content

Fix inf test ci #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix inf test ci #140

wants to merge 2 commits into from

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented May 20, 2025

I'm guessing that the parallel writes to GITHUB_OUTPUT env var are causing the test CI to behave as if the workflow never finishes.

This patch, hopefully, should fix that by changing the env var's value to a temp file created during the test.

This also includes new clippy fixes using stable rust v1.87.

2bndy5 added 2 commits May 19, 2025 22:00
I'm guessing that the parallel writes to GITHUB_OUTPUT env var are causing the test CI to behave as if the workflow never finishes.

This patch, hopefully, should fix that by changing the env var's value to a temp file created during the test.
using stable rust v1.87 produces new clippy fixes.
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (49a7c8d) to head (39f274c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   97.58%   97.55%   -0.03%     
==========================================
  Files          14       14              
  Lines        3430     3435       +5     
==========================================
+ Hits         3347     3351       +4     
- Misses         83       84       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2bndy5
Copy link
Collaborator Author

2bndy5 commented May 20, 2025

The test CI is still running indefinitely. even though it has finished all the steps. I'm going to have to raise this issue with GitHub itself.

@2bndy5 2bndy5 closed this May 21, 2025
@2bndy5 2bndy5 deleted the fix-inf-test-ci branch May 21, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant