-
Notifications
You must be signed in to change notification settings - Fork 21
add file-annotations option #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tested this option on the test repo. In a matrix that runs the action for all versions of clang-tools, only annotations (& thread comments) were enabled for v12. It worked as expected. |
Do you think we need to update the YAML example in README to help users avoid adding duplicate annotaions? |
* Update docs and images * Update display size
Well, following the discussion in #58, it seems that there are several ways to trigger duplicate annotations. on:
pull_request:
types: [opened, reopened] # let PR-synchronize events be handled by push events
push: The current examples use on:
push:
paths-ignore: "docs/**"
pull_request:
paths-ignore: "docs/**" |
I like your propose 👍 |
Kudos, SonarCloud Quality Gate passed!
|
I accidentally rebased on an older commit in master, so the commits in #57 now show in this branch's history. Please squash and merge this when ready. |
OK. do you know why the PR action is queued https://github.com/shenxianpeng/test-cpp-linter-action/actions/runs/2236867491
|
I have no idea. I tried canceling the run (hoping to manually re-start it), but I got a error message from github saying "Failed to cancel workflow." It doesn't seem to be related. Sometimes, I see a runner in queue when waiting for a github hosted VM to become available, but it doesn't even say that much. 🤷🏼♂️ |
It looks like a github problem. I see you closed and re-opened the PR which seemed to have expected results. |
OK, I'm going to squash and merge. |
Add an option to enable/disable the use of file annotations. This includes changes to the README,
so there might be a conflict with #57.