-
Notifications
You must be signed in to change notification settings - Fork 21
feat: add release-drafter.yml #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't fully understand how the config works. In order to use categories, I think we need to create a few labels (for each cpp-linter repo). Then add the right label to certain PRs so release-drafter will categorize them accordingly. Maybe I'm misunderstanding this entirely. |
According to the release-drafter docs, the resolved version defaults to a patch bump. To make it bump a minor or major version, we need to add new labels named "major" and "minor". |
We need to add major, minor, and patch labels for all repos for the auto-suggest version feature. we can maintain all labels here https://github.com/organizations/cpp-linter/settings/repository-defaults |
The above link to the setting is only applies to new repo. for the existing repo we need to add related labels manually 😢 |
I think it's ready for review. let's see how it works 😃 If this repo works as we expect, I will make the same changes to other repos later. |
It worked! A release for v2.7.7 was just drafted. |
Yeah, it seems will draft for each merge. Anyway, we can decide whether we need to publish it or not. |
I think this also means no more quick commits to default branches. Seems release-drafter will only work for PR merges? |
Yes. Right now it works for any new changes made on the main branch |
I mean only for PRs, not for a direct commit to the main branch. right? |
Oh yes, I think so. |
Here, we used the default configuration in git cpp-linter/.github/release-drafter.yml. However, it can be overwritten if needed.