-
Notifications
You must be signed in to change notification settings - Fork 771
Use \keyword pervasively #4405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use \keyword pervasively #4405
Conversation
521906f
to
f70682b
Compare
@jensmaurer If you rebase this, I think this can land -- it has no visual effect, right? |
c15f935
to
479fdc2
Compare
@tkoeppe: Rebased. Confirmed no visual effect, except one strange false positive / spacing diff shown by diffpdf, and (of course) except for the additional index entries. |
@tkoeppe, we should consider squashing this. |
I extraced a nesting fix into b0a253c; please rebase. |
Well, I can actually just fix this myself, so leave it with me. |
Hm... That situation is actually fine in my copy. But apparently, I need to rebase. @tkoeppe, rebased. |
Hm, you lost the |
Are we talking about the same thing? I have
|
(These are parens around a parameter-type-list; the closing paren is at the end.) |
The "function of" issue was a problem with your PR, which you have now fixed. The const_cast nesting issue was pre-existing, and your PR had fixed it, but I extraced it into a separate commit (since it has nothing to do with |
Yes, and I've rebased/force-pushed and fixed the "function of" issue. Are there any other issues? |
No, that should be it. |
Slightly related to #4401