Skip to content

feat(header): use routerLink for brand instead of href attribute #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2019
Merged

feat(header): use routerLink for brand instead of href attribute #51

merged 1 commit into from
Feb 19, 2019

Conversation

Hagith
Copy link
Contributor

@Hagith Hagith commented Feb 19, 2019

Using href causes page reload what is not welcome in SPA.

@xidedix xidedix merged commit 3b4d98d into coreui:master Feb 19, 2019
@xidedix
Copy link
Member

xidedix commented Feb 19, 2019

@Hagith - good catch, thanks!

@Hagith Hagith deleted the header-brand-router-link branch February 19, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants