Skip to content

app-sidebar-nav-label.component sets an incomplete variant style #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coyoteecd opened this issue Jul 30, 2019 · 0 comments · Fixed by #76
Closed

app-sidebar-nav-label.component sets an incomplete variant style #75

coyoteecd opened this issue Jul 30, 2019 · 0 comments · Fixed by #76

Comments

@coyoteecd
Copy link
Contributor

I think there's a small bug in app-sidebar-nav-label.component.ts, at this line:

    const variant = `text-${this.item.label.variant}`;
    classes[variant] = !!variant;

There, !!variant will always evaluate to true, because of the interpolated string. Consequence is that a dummy text- class will be added to the label items. Small bug, but easy to fix.

xidedix added a commit that referenced this issue Aug 2, 2019
@xidedix xidedix mentioned this issue Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant