Skip to content

cIcon directive change name binding not refresh icon in angular 17 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ProDInfo opened this issue Apr 12, 2024 · 2 comments
Closed

cIcon directive change name binding not refresh icon in angular 17 #203

ProDInfo opened this issue Apr 12, 2024 · 2 comments
Assignees
@xidedix

Comments

@ProDInfo
Copy link

Bug reports must include:

  • Operating system and version Windows 11
  • Browser and version: Edge 123.0.2420.81

The code work on angular 16 and core UI 4.7 but upgrade to angular 17 no work, only load the first time but update the variable icon no refresh:

<button cButton cDropdownToggle class="px-2">
  <svg cIcon [name]="icon"></svg>
</button>`
@xidedix xidedix self-assigned this Apr 15, 2024
@xidedix
Copy link
Member

xidedix commented Apr 15, 2024

@ProDInfo we can confirm the issue

xidedix added a commit that referenced this issue Apr 15, 2024
@xidedix
fix(icon): cIcon directive [name] binding does not refresh icon for A…
82180e5 
…ngular 17 #203, refactor
xidedix added a commit that referenced this issue Apr 15, 2024
@xidedix
fix(icon): cIcon directive [name] binding does not refresh icon for A…
e880da0 
…ngular 17, refactor, closes #203, thanks @ProDInfo
@xidedix
Copy link
Member

xidedix commented Apr 15, 2024

@ProDInfo thanks for heads-up!

fixed in @coreui/icons-angular:

  • 4.7.19
  • 5.0.2

@xidedix xidedix closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xidedix xidedix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ProDInfo @xidedix